Issue 77928 - RTL should not be default writing direction for formulas
Summary: RTL should not be default writing direction for formulas
Status: CONFIRMED
Alias: None
Product: Calc
Classification: Application
Component: formatting (show other issues)
Version: OOo 2.2
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-30 11:35 UTC by alan
Modified: 2017-05-20 11:13 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description alan 2007-05-30 11:35:13 UTC
Writing formulas should be done with LTR text direction, even in RTL OOo. Since
formulas begin with an equals sign, and the formula names are in English,
default  RTL direction is inappropriate. In my patch to Issue 72028, I included
a fix for this, and Niklas Nebel had some comments on the subject. Following
Niklas Nebel's suggestion, I am creating a new issue, and we can continue the
discussion here.
Comment 1 alan 2007-05-31 15:43:14 UTC
in Issue 72028 nn wrote:

>The default for ATTR_WRITINGDIR is to use the value from the page style, and in
>the page style it is already locale-dependent (see ScStyleSheet::GetItemSet).
>There's no point in overriding this again with the view. Also, are you sure that
>the default should be LTR, or is some special handling for formulas needed? That
>should be a separate issue.

->nn:
Perhaps I should not yet say whether or not the best way to go is by making the
default text dirction LTR. For me, this was simpler than adding special handling
for formulas. We've released a Hebrew version of 2.2 using default LTR text
direction, and we will be monitoring user reaction. So after we get user
feedback, I'll be in a better position to know whether RTL users have a problem
with this, or whether there should be special handling for formulas.

If we do set the default text direction to LTR, then where should it be changed?
The locale-dependent writing direction in ScStyleSheet::GetItemSet yields RTL,
the opposite of what's needed for formulas. So it could be changed there. But is
there a special reason that text direction isn't set in the default style like
alignment is?
Comment 2 alan 2007-05-31 15:47:18 UTC
in Issue 72028 nn wrote:

>The default for ATTR_WRITINGDIR is to use the value from the page style, and in
>the page style it is already locale-dependent (see ScStyleSheet::GetItemSet).
>There's no point in overriding this again with the view. Also, are you sure that
>the default should be LTR, or is some special handling for formulas needed? That
>should be a separate issue.

->nn:
Perhaps I should not yet say whether or not the best way to go is by making the
default text dirction LTR. For me, this was simpler than adding special handling
for formulas. We've released a Hebrew version of 2.2 using default LTR text
direction, and we will be monitoring user reaction. So after we get user
feedback, I'll be in a better position to know whether RTL users have a problem
with this, or whether there should be special handling for formulas.

If we do set the default text direction to LTR, then where should it be changed?
The locale-dependent writing direction in ScStyleSheet::GetItemSet yields RTL,
the opposite of what's needed for formulas. So it could be changed there. But is
there a special reason that text direction should be set in the default style
and text alignment in the view (as it is in your patch to 72028)?
Comment 3 frank 2007-07-10 10:18:04 UTC
Hi Niklas,

as you're involved here, re-assigned to you.

Frank
Comment 5 alan 2007-10-28 15:32:51 UTC
So far, we've seen one problem with setting the default text-direction to LTR in
our Hebrew version. When running DataPilot, the “DataPilot Category†style used
by the resulting table inherits the text-direction from the default style, and
the resulting table in Hebrew does not always look right. It needs RTL text
direction. 

(It also needs RTL alignment, which is set in the view. I asked in a previous
post why the alignment should be set in the view and not in the default style.)

It could be that other problems like this may surface in the future. I tend to
agree with your suggestion that the default style's text-direction should be
RTL, and that formulas should have special handling and have LTR text-direction.
But is this easily implemented? If you do it, will you have time available in
the near future? If you don't have time, I am willing to help out do, but I
would need some direction about where the code should be changed so that only
the formulas will have LTR text direction.
Comment 6 alan 2008-10-23 09:11:28 UTC
Hi Niklas,

Have you been able to work on the special handling for formulas in RTL?

Alan
Comment 7 Marcus 2017-05-20 11:13:51 UTC
Reset assigne to the default "issues@openoffice.apache.org".